Typescript support

[william0bra]

Typescript would be great here.

[karmaniverous]

Not a TS guy. Can you explain the issue a little more deeply?

[welkinwong]

same, need ts

[karmaniverous]

Ok guys I hear the request. Not a TS guy myself and don't have any need of it for my own projects, but I'm happy to roll a revision in if you care to make it.

That said: why is it so important? The code works and the JSDoc provides intellisense support. Shouldn't TS just bundle this package as-is? Makes me wonder if there's an issue with the package config.

[welkinwong]

Ok guys I hear the request. Not a TS guy myself and don't have any need of it for my own projects, but I'm happy to roll a revision in if you care to make it.

That said: why is it so important? The code works and the JSDoc provides intellisense support. Shouldn't TS just bundle this package as-is? Makes me wonder if there's an issue with the package config.

in ourselves project, this will be throw an error message and highline code

[karmaniverous]

Hm ok I think I caught the gist of that.

Making this thing work with TS is probably more than I am equipped to take on. That will require the assistance of somebody who is familiar with TS, although I would LOVE to learn what I'm doing that is breaking TS!

A suggestion: the project isn't really super complicated. You could probably fork it and in an afternoon either...

1. refactor it into TS or
2. get the packaging working for TS.

If you do number 2 I would be delighted to review & incorporate your changes.

[karmaniverous]

P.S. Another thought... have you updated to the latest release? I populated the deprecated main key in package.json to support VS Code IntelliSense and who knows but that might have been breaking TS as well.

[drabelogarner]

To get this halfway there, you can add the types manually.

Create a global.d.ts file and add this

declare module '@karmaniverous/serify-deserify' {
  let createReduxMiddleware: () => any;
  let deserify: <T>(obj: any) => T;
  let serify: <T>(obj: any) => T;
}

Then pass in a type when calling deserify.

const date = deserify< Date >(selectDate);

[karmaniverous]

@drabelogarner that's a great idea thank you!! Standing by for your PR. 😁

[karmaniverous]

For those of you who are still paying attention: I guess now I'm a TypeScript guy. 🤣 Should have a TS release of this in a few days!

[karmaniverous]

This is done! serify-deserify is now fully type safe. See the README for more info and please don't hesitate to ping me with any questions!