Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to minimize the rbac for Karmada credentials in member cluster #5721

Open
NickYadance opened this issue Oct 23, 2024 · 1 comment
Open
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@NickYadance
Copy link

What happened:

Karmada will generate a clusterrole with super high privileges when join member cluster in Push mode, which brings security risk into member cluster. Can we minimize the privileges of this clusterrole instead of '*' ?

k -n karmada-cluster get clusterroles karmada-controller-manager:xx -oyaml                       ok  4s  base py  10:12:57
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: karmada-controller-manager:xx
rules:
- apiGroups:
  - '*'
  resources:
  - '*'
  verbs:
  - '*'
- nonResourceURLs:
  - '*'
  verbs:
  - get

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Karmada version:
  • kubectl-karmada or karmadactl version (the result of kubectl-karmada version or karmadactl version):
  • Others:
@NickYadance NickYadance added the kind/bug Categorizes issue or PR as related to a bug. label Oct 23, 2024
@zhzhuang-zju
Copy link
Contributor

@NickYadance Could you describe what security risk might arise? This ClusterRole is used for the control plane to connect to the member clusters. For the control plane, it needs all permissions on the member clusters to manage their resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: No status
Development

No branches or pull requests

2 participants