Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

Commit 5fed790

Browse files
committed
fix: do not ser return_url to allow auto-watch
This does not really fix the issue (as described in #9). It’s not possible to navigate to about:blank page through browserstack API - we would have to use WebDriver instead, which is in general significantly slower. I tested this a couple of times and it looks like the issue does not exist with BS (we used to have this problem with SL) - BS really kills the browser before the terminateWorker response is sent so I hope the re-capturing old browsers should not be an issue. Closes #9
1 parent fe8b480 commit 5fed790

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

index.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,7 @@ var BrowserStackBrowser = function(id, emitter, args, logger,
102102
tunnelIdentifier: bsConfig.tunnelIdentifier,
103103
// TODO(vojta): remove "version" (only for B-C)
104104
browser_version: args.browser_version || args.version || 'latest',
105-
// TODO(vojta): do not use return_url (it only works with single run)
106-
url: url + '?id=' + id + '&return_url=about:blank',
105+
url: url + '?id=' + id,
107106
'browserstack.tunnel': true,
108107
timeout: bsConfig.timeout || 300,
109108
project: bsConfig.project,

0 commit comments

Comments
 (0)