Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move content of .vim file to explicit lua initialisation by user #7

Closed
matu3ba opened this issue Apr 4, 2021 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@matu3ba
Copy link

matu3ba commented Apr 4, 2021

I like the plugin very much. Thanks alot for creating!

Reasons to do:

  1. A pure lua profile would decrease startup time.
  2. The lua startup profiler would be more correct or simpler to get correct with this change. Otherwise one gets more wrong results.
  3. Try to be consistent as to use functionality of lua, if possible.
  4. Having a function to initialize makes separating things for user-specific settings while getting updates much easier (user may implement a different function to customize plugin).

Another related reason (bad practice/historical reasons): nvim-treesitter/module-template#1

Relevant content for change:
https://github.com/nanotee/nvim-lua-guide#using-meta-accessors-1

Is the problem potentially that there is standard way to define description + maintainer for tools to read?

" Smooth scrolling plugin
" Maintainer: Carles Rafols i Belles

Sidenode: Luajit caches stuff (for speed reasons), so when no vimscript is involved or a function changes settings, they will remain.

@karb94
Copy link
Owner

karb94 commented Apr 4, 2021

Thank you for letting me know about this. The only reason why I haven't done this yet is my ignorance :) (this is my first plugin). I'll look into this.

@karb94
Copy link
Owner

karb94 commented Apr 5, 2021

See if the changes in 90d8f58 are sufficient. The README.md has a sample setup function you can copy.

@karb94 karb94 closed this as completed Apr 5, 2021
@karb94 karb94 added the enhancement New feature or request label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants