-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verbatim shouldn't create a wrapper div #200
Comments
Agreed. |
agreed; if you have a working PR that avoids creating a div with verbatim, then #160 can be closed |
#160 is incorrect anyways. Example: let node = "This is an inner div <div>inner div</div>".verbatimRaw
# node == VNode("This is an inner div ") It completely discards any other children. You probably shouldn't do this anyways (not the point of verbatim), but it also shouldn't result in discarded data. The reason why verbatim currently uses a div is because of the above. To capture many children in one node. The way around this would be to make |
I recall that React has a special |
Hmm, that could work as well |
other frameworks append custom html comments to solve this problem iirc: <!-- start arbitrary text #1 -->
...
<!-- end arbitrary text #1 --> |
Completed in #270 |
…m#270)" (karaxnim#274) This reverts commit 8e0f471.
Using
verbatim
shouldn't cause a wrapper div to be created, it isn't always the desired behavior.#160 tries addressing this with a new
verbatimRaw
, but I would suggest just not having verbatim create a div at all, it is super easy for the user to add a wrapper div if needed. Also,verbatim
must have a parent HTML element anyway.I'd also argue that it is pretty unintuitive for a hidden element to be created if you just want to display something like
&
properly.The text was updated successfully, but these errors were encountered: