Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match the signing alg with id_key alg #12

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Match the signing alg with id_key alg #12

merged 1 commit into from
Dec 10, 2023

Conversation

dmulder
Copy link
Collaborator

@dmulder dmulder commented Dec 7, 2023 •
edited
Loading

Implements # .

  • cargo fmt has been run
  • cargo test has been run and passes
  • documentation has been updated with relevant examples (if relevant)

@dmulder
Copy link
Collaborator Author

dmulder commented Dec 7, 2023

I found this bug when signing a JWT with a Rsa2048 id_key in himmelblau. compact-jwt was setting the signing algorithm to ES256 regardless of the id_key algorithm.
FYI, I think this was missed because there is no test for Rsa2048/RS256.

@Firstyear Firstyear merged commit d9875de into kanidm:main Dec 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Firstyear Firstyear Firstyear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmulder @Firstyear