Skip to content

Commit 7b0e0c6

Browse files
committed
clover: Treewide: Cleanup and Reorder
* Remove Double Definition * Reordeder Alphabetic * Move Audio and Media Files to Configs * Move sensor files to configs * Reorder Properties * Fix whitespaces
1 parent 35b0612 commit 7b0e0c6

7 files changed

+43
-58
lines changed

carbon_clover.mk

+1-3
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ $(call inherit-product, vendor/carbon/config/common.mk)
3333
# Define first api level
3434
$(call inherit-product, $(SRC_TARGET_DIR)/product/product_launched_with_o_mr1.mk)
3535

36-
DEVICE_PATH := device/xiaomi/clover
37-
3836
# CarbonRom Maintainer
3937
PRODUCT_PROPERTY_OVERRIDES += \
4038
ro.carbon.maintainer="Rcstar6696"
@@ -49,4 +47,4 @@ PRODUCT_MODEL := MI PAD 4
4947

5048
# Build Fingerprint
5149
PRODUCT_BUILD_PROP_OVERRIDES += \
52-
PRIVATE_BUILD_DESC="clover-user 8.1.0 OPM1.171019.019 9.7.4 release-keys"
50+
PRIVATE_BUILD_DESC="clover-user 8.1.0 OPM1.171019.019 9.7.4 release-keys"
File renamed without changes.
File renamed without changes.
File renamed without changes.

device.mk

+17-17
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,10 @@ $(call inherit-product, device/xiaomi/sdm660-common/sdm660.mk)
2828
# Device Path
2929
DEVICE_PATH := device/xiaomi/clover
3030

31-
# Soong
32-
PRODUCT_SOONG_NAMESPACES += \
33-
$(DEVICE_PATH)
34-
35-
# Overlays
36-
DEVICE_PACKAGE_OVERLAYS += \
37-
$(DEVICE_PATH)/overlay
38-
3931
# Audio
4032
PRODUCT_COPY_FILES += \
41-
$(DEVICE_PATH)/audio/audio_platform_info_intcodec.xml:$(TARGET_COPY_OUT_VENDOR)/etc/audio_platform_info_intcodec.xml \
42-
$(DEVICE_PATH)/audio/mixer_paths.xml:$(TARGET_COPY_OUT_VENDOR)/etc/mixer_paths.xml
33+
$(DEVICE_PATH)/configs/audio/audio_platform_info_intcodec.xml:$(TARGET_COPY_OUT_VENDOR)/etc/audio_platform_info_intcodec.xml \
34+
$(DEVICE_PATH)/configs/audio/mixer_paths.xml:$(TARGET_COPY_OUT_VENDOR)/etc/mixer_paths.xml
4335

4436
# Boot animation
4537
TARGET_SCREEN_HEIGHT := 1920
@@ -50,32 +42,40 @@ $(call inherit-product, $(DEVICE_PATH)/device_prop.mk)
5042

5143
# Media
5244
PRODUCT_COPY_FILES += \
53-
$(DEVICE_PATH)/media/media_profiles_V1_0.xml:$(TARGET_COPY_OUT_VENDOR)/etc/media_profiles_V1_0.xml
45+
$(DEVICE_PATH)/configs/media/media_profiles_V1_0.xml:$(TARGET_COPY_OUT_VENDOR)/etc/media_profiles_V1_0.xml
5446

5547
# Keylayout
5648
PRODUCT_COPY_FILES += \
57-
$(DEVICE_PATH)/configs/keylayout/sdm660-snd-card_Button_Jack.kl:$(TARGET_COPY_OUT_VENDOR)/usr/keylayout/sdm660-snd-card_Button_Jack.kl
49+
$(DEVICE_PATH)/configs/keylayout/sdm660-snd-card_Button_Jack.kl:$(TARGET_COPY_OUT_VENDOR)/usr/keylayout/sdm660-snd-card_Button_Jack.kl
50+
51+
# Overlays
52+
DEVICE_PACKAGE_OVERLAYS += \
53+
$(DEVICE_PATH)/overlay
5854

5955
# Permissions
6056
PRODUCT_COPY_FILES += \
61-
frameworks/native/data/etc/android.hardware.camera.autofocus.xml:$(TARGET_COPY_OUT_VENDOR)/etc/permissions/android.hardware.camera.autofocus.xml
57+
frameworks/native/data/etc/android.hardware.camera.autofocus.xml:$(TARGET_COPY_OUT_VENDOR)/etc/permissions/android.hardware.camera.autofocus.xml
6258

6359
# Ramdisk
6460
PRODUCT_PACKAGES += \
65-
init.device.rc \
66-
init.macaddress_setup.sh
61+
init.device.rc \
62+
init.macaddress_setup.sh
6763

6864
# Screen density
6965
PRODUCT_AAPT_CONFIG := large
7066
PRODUCT_AAPT_PREF_CONFIG := xhdpi
7167

7268
# Sensors
7369
PRODUCT_COPY_FILES += \
74-
$(DEVICE_PATH)/sensors/sensor_def_qcomdev.conf:$(TARGET_COPY_OUT_VENDOR)/etc/sensors/sensor_def_qcomdev.conf
70+
$(DEVICE_PATH)/configs/sensors/sensor_def_qcomdev.conf:$(TARGET_COPY_OUT_VENDOR)/etc/sensors/sensor_def_qcomdev.conf
71+
72+
# Soong
73+
PRODUCT_SOONG_NAMESPACES += \
74+
$(DEVICE_PATH)
7575

7676
# Tablet features
7777
PRODUCT_COPY_FILES += \
78-
frameworks/native/data/etc/tablet_core_hardware.xml:$(TARGET_COPY_OUT_VENDOR)/etc/permissions/tablet_core_hardware.xml
78+
frameworks/native/data/etc/tablet_core_hardware.xml:$(TARGET_COPY_OUT_VENDOR)/etc/permissions/tablet_core_hardware.xml
7979

8080
# Vendor files
8181
$(call inherit-product, vendor/xiaomi/clover/clover-vendor.mk)

device_prop.mk

+25-38
Original file line numberDiff line numberDiff line change
@@ -23,56 +23,43 @@
2323

2424
# ACDB
2525
PRODUCT_PROPERTY_OVERRIDES += \
26-
persist.audio.calfile0=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Bluetooth_cal.acdb \
27-
persist.audio.calfile1=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_General_cal.acdb \
28-
persist.audio.calfile2=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Global_cal.acdb \
29-
persist.audio.calfile3=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Handset_cal.acdb \
30-
persist.audio.calfile4=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Hdmi_cal.acdb \
31-
persist.audio.calfile5=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Headset_cal.acdb \
32-
persist.audio.calfile6=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Speaker_cal.acdb \
33-
persist.audio.calfile7=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_workspaceFile.qwsp \
34-
persist.audio.calfile8=/vendor/etc/acdbdata/adsp_avs_config.acdb \
35-
persist.audio.calfile0D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Bluetooth_cal.acdb \
36-
persist.audio.calfile1D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_General_cal.acdb \
37-
persist.audio.calfile2D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Global_cal.acdb \
38-
persist.audio.calfile3D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Handset_cal.acdb \
39-
persist.audio.calfile4D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Hdmi_cal.acdb \
40-
persist.audio.calfile5D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Headset_cal.acdb \
41-
persist.audio.calfile6D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Speaker_cal.acdb \
42-
persist.audio.calfile7D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_workspaceFile.qwsp \
43-
persist.audio.calfile8D9P=/vendor/etc/acdbdata/adsp_avs_config.acdb
26+
persist.audio.calfile0=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Bluetooth_cal.acdb \
27+
persist.audio.calfile1=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_General_cal.acdb \
28+
persist.audio.calfile2=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Global_cal.acdb \
29+
persist.audio.calfile3=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Handset_cal.acdb \
30+
persist.audio.calfile4=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Hdmi_cal.acdb \
31+
persist.audio.calfile5=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Headset_cal.acdb \
32+
persist.audio.calfile6=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_Speaker_cal.acdb \
33+
persist.audio.calfile7=/vendor/etc/acdbdata/QRD/sdm660-snd-card-skush/QRD_SKUSH_workspaceFile.qwsp \
34+
persist.audio.calfile8=/vendor/etc/acdbdata/adsp_avs_config.acdb \
35+
persist.audio.calfile0D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Bluetooth_cal.acdb \
36+
persist.audio.calfile1D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_General_cal.acdb \
37+
persist.audio.calfile2D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Global_cal.acdb \
38+
persist.audio.calfile3D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Handset_cal.acdb \
39+
persist.audio.calfile4D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Hdmi_cal.acdb \
40+
persist.audio.calfile5D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Headset_cal.acdb \
41+
persist.audio.calfile6D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_Speaker_cal.acdb \
42+
persist.audio.calfile7D9P=/vendor/etc/acdbdata/QRD/sdm660-snd-card-d9p/QRD_D9P_workspaceFile.qwsp \
43+
persist.audio.calfile8D9P=/vendor/etc/acdbdata/adsp_avs_config.acdb
4444

4545
# Audio
4646
PRODUCT_PROPERTY_OVERRIDES += \
47-
ro.vendor.audio.sdk.fluencetype=fluence \
48-
persist.vendor.audio.fluence.voicecall=true \
49-
persist.vendor.audio.fluence.voicerec=true \
50-
persist.vendor.audio.fluence.speaker=true \
51-
persist.vendor.audio.fluence.audiorec=true \
52-
vendor.audio.adm.buffering.ms=3 \
53-
vendor.audio.offload.track.enable=true
47+
persist.vendor.audio.fluence.audiorec=true
5448

5549
# Camera
5650
PRODUCT_PROPERTY_OVERRIDES += \
57-
persist.radio.VT_CAM_INTERFACE=1 \
58-
persist.camera.stats.test=5 \
59-
persist.camera.HAL3.enabled=1 \
60-
persist.camera.preview.ubwc=0
51+
persist.camera.stats.test=5 \
52+
persist.camera.HAL3.enabled=1 \
53+
persist.camera.preview.ubwc=0
6154

6255
# Display
6356
PRODUCT_PROPERTY_OVERRIDES += \
64-
debug.sf.recomputecrop=0 \
65-
debug.vds.allow_hwc=0
66-
67-
# System property for color temperature
68-
PRODUCT_PROPERTY_OVERRIDES += \
69-
ro.colorpick_adjust=true \
70-
ro.df.effect.conflict=1
57+
debug.vds.allow_hwc=0
7158

7259
# Single SIM
7360
PRODUCT_PROPERTY_OVERRIDES += \
74-
persist.radio.multisim.config=ssss
61+
persist.radio.multisim.config=ssss
7562

7663
# Ultra Sound
7764
PRODUCT_PROPERTY_OVERRIDES += \
78-
audio.chk.cal.us=0
65+
audio.chk.cal.us=0

0 commit comments

Comments
 (0)