Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 2 Goertzel filters instead of the FFT #50

Open
aguaviva opened this issue Jun 29, 2021 · 1 comment · May be fixed by #51
Open

use 2 Goertzel filters instead of the FFT #50

aguaviva opened this issue Jun 29, 2021 · 1 comment · May be fixed by #51

Comments

@aguaviva
Copy link

aguaviva commented Jun 29, 2021 •
edited
Loading

Given that you are using only 2 symbols I'd be faster to use a goertzel filter instead of using a full FFT, this will also reduce the dependecy with FFTW and will simplify the fsk part in size and complexity :)

more info: https://en.wikipedia.org/wiki/Goertzel_algorithm

Actually it will be an honor to send you a MR :)
@aguaviva aguaviva linked a pull request Jun 30, 2021 that will close this issue
Open
@kamalmostafa
Copy link
Owner

Hi @aguaviva -- Did you receive my email 2021-07-17 Subject: "minimodem Goertzel implementataion"? Please reply, or let me know here if you didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using a Goertzel filter instead of using the fft aguaviva/minimodem
2 participants
@kamalmostafa @aguaviva