Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to *App types #118

Open
lolmaus opened this issue Dec 9, 2020 · 0 comments
Open

Refactor to *App types #118

lolmaus opened this issue Dec 9, 2020 · 0 comments

Comments

@lolmaus
Copy link
Contributor

lolmaus commented Dec 9, 2020

Current usage:

import { ConfigurationState as BaseCofigurationState } from '@kaliber5/foo';

export interface ConfigurationState extends BaseConfigurationState;

This is problematic because when I try to use ConfigurationState, IDE would suggest the base one from the addon, and there is confusion.

Not renaming ConfigurationState resolves the confusion:

import { ConfigurationState } from '@kaliber5/foo';

export interface ConfigurationStateApp extends BaseConfigurationState;

Note: I suggest that we use App as suffix rather than prefix because it easier to see intention: Foo-something, Bar-something is more visible than App-something, App-somethings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant