Introduce a build_path variable

[RobLoach]

It should be exposed through the twigshim hook.

It should default to base_path() . kalastatic_base . kalastatic_destination.

https://api.drupal.org/api/drupal/includes!common.inc/function/base_path/7.x

[hawkeyetwolf]

Hey @RobLoach, did we need build_path when rendering Twig templates from Drupal for any reason? It breaks image paths we pass into the Twig templates. Talked it over with @thiagodemellobueno and it seems that when rendering from Drupal, we are not in fact supposed to have this variable set. Okay if we take it out?

[RobLoach]

build_path breaks images in Drupal? Just having the variable shouldn't break things. This on PROG? I'd rather fix it in there....
https://kalamuna.atlassian.net/browse/PROGMI-242

Do you have a link to see where it's broken?

The aim of build_path is to represent the path in which KalaStatic was built to. The workaround we used when this wasn't available is src_root.

[hawkeyetwolf]

@RobLoach is anything still needed here? I think we cleaned up the problem and are on the same page about how/why build_path was giving us a headache (if more 'splanation is needed, lemme know). We talked about a more permanent solution last week but not sure how far we got with implementing it.

[RobLoach]

@derekderaps Think Josh decided static_asset_path was a better name:
https://github.com/kalamuna/kalastatic_dot_module/blob/7.x-2.x/kalastatic.module#L357

In PROGMI, the solution was to get rid of it all and have all image paths prefix /kalastatic/ manually, avoiding the issue all together.

[hawkeyetwolf]

re:

In PROGMI, the solution was to get rid of it all and have all image paths prefix /kalastatic/ manually, avoiding the issue all together.

Smart one! Thanks