Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Magit Commit closes workspace #316

Open
Aduril opened this issue Nov 19, 2024 · 5 comments · May be fixed by #322
Open

Bug: Magit Commit closes workspace #316

Aduril opened this issue Nov 19, 2024 · 5 comments · May be fixed by #322

Comments

@Aduril
Copy link

Aduril commented Nov 19, 2024

Hello everyone,

I just noticed a problem when working with workspaces:

When I run magit commit within a workspace, the editor for the commit message opens a new window (while killing the old one).
If I should provide any other configuration, I can provide it :)

image

Edit: I just did a rollback and now it works properly again.

@Aduril
Copy link
Author

Aduril commented Nov 20, 2024

Hey,

to illustrate this bug a little more, I created a setup that illustrates the error.
Simply run the script and try to commit something. The current workspace will be colsed and a new window is created with the commit buffer

@sakshamsharma
Copy link

I hit the same bug after vscode updated my extension to 0.6.64. I was able to make it work by downgrading to 0.6.62 and now it works fine, same as the author of this issue I guess.

In my case, I have a remote workspace that I work in, and then when I try to "commit" it opens a new SSH window but loses the workspace.

In the changelog I see: "Window re-use logic for mono repos". That looks related. Presumably this?
3fa9a37

@adbl
Copy link

adbl commented Nov 21, 2024

Yep, also hitting this with a workspace setup.

@westlywright
Copy link

Same here. I work in a monorepo that contains a backend and multiple different front-ends, all have they're own workspaces. Rolled back to 0.6.62 until this is resolved.

@ieugen
Copy link

ieugen commented Nov 26, 2024

I am getting the same result with codium, I have a workspace with 3 dirs / git repos open .

Downgrading to 0.6.62 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants