Skip to content

Commit

Permalink
FE: Consumers: Fix lag is displayed as 'N/A' in case of null value (#720
Browse files Browse the repository at this point in the history
)
  • Loading branch information
K-Diger authored Jan 6, 2025
1 parent 00ebb0d commit 91f95f6
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 1 deletion.
2 changes: 1 addition & 1 deletion frontend/src/components/ConsumerGroups/List.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const List = () => {
header: 'Consumer Lag',
accessorKey: 'consumerLag',
cell: (args) => {
return args.getValue() || 'N/A';
return args.getValue() ?? 'N/A';
},
},
{
Expand Down
55 changes: 55 additions & 0 deletions frontend/src/components/ConsumerGroups/__test__/List.spec.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import React from 'react';
import { screen } from '@testing-library/react';
import { render } from 'lib/testHelpers';
import { useConsumerGroups } from 'lib/hooks/api/consumers';
import List from 'components/ConsumerGroups/List';

// Mock hooks
jest.mock('lib/hooks/api/consumers', () => ({
useConsumerGroups: jest.fn(),
}));

jest.mock('react-router-dom', () => ({
...jest.requireActual('react-router-dom'),
useSearchParams: () => [new URLSearchParams(), jest.fn()],
useNavigate: () => jest.fn(),
}));

const mockUseConsumerGroups = useConsumerGroups as jest.Mock;

describe('ConsumerGroups List', () => {
beforeEach(() => {
mockUseConsumerGroups.mockImplementation(() => ({
data: {
consumerGroups: [
{
groupId: 'group1',
consumerLag: 0,
members: 1,
topics: 1,
coordinator: { id: 1 },
state: 'STABLE',
},
{
groupId: 'group2',
consumerLag: null,
members: 1,
topics: 1,
coordinator: { id: 2 },
state: 'STABLE',
},
],
pageCount: 1,
},
isSuccess: true,
isFetching: false,
}));
});

it('renders consumer lag values correctly', () => {
render(<List />);
const tableRows = screen.getAllByRole('row');
expect(tableRows[1]).toHaveTextContent('0');
expect(tableRows[2]).toHaveTextContent('N/A');
});
});

0 comments on commit 91f95f6

Please sign in to comment.