Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onbuild:Dockerfile still points to meteorhacks base image #10

Open
manueldelreal opened this issue Aug 24, 2016 · 4 comments
Open

onbuild:Dockerfile still points to meteorhacks base image #10

manueldelreal opened this issue Aug 24, 2016 · 4 comments

Comments

@manueldelreal
Copy link

manueldelreal commented Aug 24, 2016

Is the onbuild dockerfile going to be updated at some point to point to your own base rather than meteorhacks'? or are you keeping it intact because of people that are still using meteor 1.3.x and building from this repo/docker images?

asking for a friend

@bompi88
Copy link

bompi88 commented Sep 4, 2016

+1

@bompi88
Copy link

bompi88 commented Sep 4, 2016

While waiting you could do something like this, in your own Dockerfile:

FROM kadirahq/meteord:base

COPY ./ /app
RUN bash $METEORD_DIR/on_build.sh

.... your stuff here

@manueldelreal
Copy link
Author

thanks @bompi88 I already have a setup like that, but it will be better to eliminate that "redundancy" at some point and just use the community supported image.

@0o-de-lally
Copy link

@arunoda will you accept a pull requests with edits to the readme ?
PS. duplicate issue: #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants