Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit panel doesn't show #147

Open
yceballost opened this issue Apr 2, 2020 · 16 comments
Open

Commit panel doesn't show #147

yceballost opened this issue Apr 2, 2020 · 16 comments

Comments

@yceballost
Copy link

Describe the bug

After a change, commit panel is hide.

Version & OS

Version 0.3.27
OS Catalina 10.15.3

Steps to reproduce the behavior

  1. Make a change in a sketch file
  2. Go to Kactus
  3. Try to commit, but the commit panel doesn't appear.

Screenshots

kactusIssue

@anthonymiao
Copy link

anthonymiao commented Apr 2, 2020

same here.
noticed on some rep, it shows, for some, it doesn't

@mathieudutour
Copy link
Member

Hum weird, it shows fine whatever I try to do.
Can you think of anything specific that would make it happen?
Otherwise, can you try to open the dev tools (cmd + alt + i), click on the small icon the top left and click on the list of changes? It should show something like
Screenshot 2020-04-02 at 22 50 02

@yceballost
Copy link
Author

Yes, I can see it

Screenshot 2020-04-02 at 23 29 57

@mathieudutour
Copy link
Member

mathieudutour commented Apr 2, 2020

and when you hover on it, it doesn't highlight anything? What is its size? (Just trying to figure out where that div has gone)

@yceballost
Copy link
Author

yceballost commented Apr 2, 2020

wow, the height is increasing crazy xD (and still increasing like a counter)

Screenshot 2020-04-02 at 23 37 02

@mathieudutour
Copy link
Member

😬 I'll try to repro

@mathieudutour
Copy link
Member

I'm publishing a new version (should be deployed in ~20min). Let me know if it fixes it

@josephs
Copy link

josephs commented Apr 3, 2020

I'm publishing a new version (should be deployed in ~20min). Let me know if it fixes it

Thanks @mathieudutour — I just updated my client, but I'm seeing the same issues other describe

@yceballost
Copy link
Author

yceballost commented Apr 3, 2020

Me too, I can't see the commit panel at the begining. But now the height is stucked in 1041px. (depends on the size of the windows when you open Kactus)

If I open Kactus and resize windows I can see the panel, but when the size of the windows arrive at the end of the commit panel, this area move down

@mathieudutour
Copy link
Member

But now the height is stucked in 1041px. (depends on the size of the windows when you open Kactus)

That's the stopgap I put yesterday. So now I know what's the issue is, but I don't know why it's happening haha. Still looking into it

@yceballost
Copy link
Author

yceballost commented Apr 3, 2020

.list-focus-container {
    max-height: 1px;
}

Solve the problem apparently (I don't believe this is the best solution, but works)

@mathieudutour
Copy link
Member

Well I really can't figure out how to reproduce so I'm just going to trust you that it fixes it and publish a new version. Doesn't seem to hurt in my case so ¯_(ツ)_/¯

@mathieudutour
Copy link
Member

publishing 0.3.29, let me know if it's fine

@yceballost
Copy link
Author

yceballost commented Apr 3, 2020

I discovered how to reproduce the issue

  1. Create a new repo
  2. Add with button "+" a new sketch file
  3. Add another sketch file
  4. Add another one

Now, you should see the commit panel is moving down

@altran-fabian
Copy link

same here version 0.3.29
in version 0.3.25 everything was fine. maybe that helps to find the reason.

@iantodd87
Copy link

I have just found the same issue, only for specific repos. On the current version 0.3.29.

Have tried multiple restarts and a machine restart with no luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants