Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Teedy version does not exist and environment variables set up wrong #1422

Open
SerialVelocity opened this issue Feb 20, 2022 · 6 comments
Open
Labels
stale Categorises a PR or issue that has not been active for a specified time.

Comments

@SerialVelocity
Copy link

Details

Helm chart name and version:
Teedy 5.5.0

Container name and tag:
v1.10

What steps did you take and what happened:

First, the chart references version teedy v1.9 (the tag no longer exists in dockerhub for some reason).

Second, when starting the chart without Postgres enabled, the container enters a CrashLoopBackOff state.

This is because the application checks whether the environment variable is null. Your helm chart is setting it to the empty string.

Relevant Helm values:

  values:
    image:
      tag: v1.10

What did you expect to happen:
The image to start.

Anything else you would like to add:

Additional Information:

@bjw-s
Copy link
Contributor

bjw-s commented Mar 29, 2022

We've bumped the image version to v1.10. We've not yet looked at the env vars though.

@ghost
Copy link

ghost commented May 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Categorises a PR or issue that has not been active for a specified time. label May 28, 2022
@SerialVelocity
Copy link
Author

This is still valid afaik

@SerialVelocity
Copy link
Author

@bjw-s How do I get the bot to remove the stale tag?

@bjw-s
Copy link
Contributor

bjw-s commented Jun 8, 2022

I just checked, and we don't set any value for the env var, not even an empty string:

the output of helm template k8s-at-home/teedy gives this:

env:
  - name: "DATABASE_PASSWORD"
    value:
  - name: "DATABASE_URL"
    value:

That should mean the env var will be present in the container but should not have a value. Since it seems the application does not handle that well, the way forward would be to comment out the default env vars completely and leave it up to the user to specify the ones they desire.

Feel free to open up a PR if we don't get around to fixing it in the meantime.

@ghost ghost removed the stale Categorises a PR or issue that has not been active for a specified time. label Jun 8, 2022
@ghost
Copy link

ghost commented Aug 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Categorises a PR or issue that has not been active for a specified time. label Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale Categorises a PR or issue that has not been active for a specified time.
Projects
None yet
Development

No branches or pull requests

2 participants