Use kubelet extra args --hostname-override value as etcd hostname?

[kke]

What happened?

As reported in a k0sctl issue, k0s always uses os.Hostname() as the etcd --name value. Maybe the value should be replicated from --kubelet-extra-args="--hostname-override=..."?

[twz123]

The kubelet runs on workers, not on controllers. So this could only meaningfully apply to controller+worker nodes. Moreover, the os.Hostname() is also used in some other places, i.e. for events emitted by k0s. I agree, the node name handling in k0s is a bit messy and scattered around in many places, including autopilot. Fixing this would require some thought, though.

Is this a cosmetic thing, or would this fix a real problem?

[kke]

k0sctl has spec: host: hostname: for overriding the hostname. This only sets the --hostname-override but it doesn't help with etcd.

[twz123]

You could also pass --name to the etcd extra args, then.

[github-actions]

The issue is marked as stale since no activity has been recorded in 30 days