Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low p-values (<= 1e-07 ) get rounded to zero #53

Open
Bullo27 opened this issue Sep 26, 2024 · 2 comments
Open

Low p-values (<= 1e-07 ) get rounded to zero #53

Bullo27 opened this issue Sep 26, 2024 · 2 comments

Comments

@Bullo27
Copy link

Bullo27 commented Sep 26, 2024

At least when run in local mode, the tool appears unable to handle p-values from 1e-07 down (not exactly this value perhaps, but 1e-06 is the last "standard" value in exponential notation that works), rounding them to zero and causing the p-value safeguard exception to be thrown.

I have done some debugging, and the values appear to be parsed correctly from the terminal (I'm running Ubuntu 22.04) and correctly written to the .yml file, but when the main C++ script parses them they are already equal to zero. The rounding appears to happen within the .cwl files.

It would be great if this could be fixed. Thanks

@shladyshau
Copy link

@Bullo27, thank you for posting this issue!
Could you provide a bit more details? Are you relating to p-values you specify in the command line, that are not handled correctly? If this is the case, we need more information on how you run SJARACNe and more details about your environment. On our side, we tested p-values as low as 10^(-9), for which the network was reconstructed successfully.

@Bullo27
Copy link
Author

Bullo27 commented Sep 27, 2024

Yes, I am referring to the -pb argument, I forgot to specify. The -pc argument seems to be handled without immediately apparent problems.

I am running the tool from a Ubuntu 22.04.5 terminal window, in a dedicated Anaconda environment in which I have only installed sjaracne so far (through the steps you recommend on this GitHub page). I am using Python 3.11.10. A few more details on what I tried to figure the issue out are reported up in the original post; if you need more details, please let me know.

The following is the command I am running:

sjaracne local -e dataset_file -o output_folder -tmp tmp_folder -g TF_list -n 1 -pb 1e-07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants