Skip to content

Commit cdd391b

Browse files
authored
docs: fix small errors (pingcap#22059)
1 parent fa95230 commit cdd391b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

docs/design/2019-11-18-tidb-with-wasm.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ a corresponding assembly language, and an interface to interact with the hosting
3434
main goal is to enable applications with high performance requirements to run on web pages. Of course,
3535
its instruction format is also designed to be able to run on other platforms.
3636

37-
The WebAssembly virtual machine has better performance than JavaScript because WebAsembly's binary
37+
The WebAssembly virtual machine has better performance than JavaScript because WebAssembly's binary
3838
format file has a more compact instruction structure, similar to ELF files (the most commonly used
3939
binary instruction format on Unix systems, which is parsed by the loader and loaded into memory for
4040
execution). WebAssembly is compiled into memory for execution by a specific runtime. The most common
@@ -100,13 +100,13 @@ the file name format is:
100100
- *_GOARCH
101101
- *_GOOS_GOARCH
102102

103-
So the only thing we need do is to add *_wasm.go, and mock an implemention based on the implemention for other platforms.
103+
So the only thing we need do is to add *_wasm.go, and mock an implementation based on the implementation for other platforms.
104104

105105
For case 2, the solution is same as case 1, because we can modify the third-party code directly.
106106

107107
For case 3 and case 4, we can’t modify the code directly. There are 3 solutions:
108108

109-
- Open issues for these repos, and ask their owners to support WebAseembly
109+
- Open issues for these repos, and ask their owners to support WebAssembly
110110
- Advantage: we don’t need to do it ourselves, and we can keep up with upstream
111111
- Disadvantage: some repos have been archived, and some are no longer maintained, nobody will reply our issue
112112
- Clone these repos to pingcap org and modify their code, then switch the reference of TiDB to the new repos.

docs/design/2020-03-12-invisible-index.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ Another solution for implement invisible indexes is: Indicate invisibility by DD
6565

6666
## Compatibility and Migration Plan
6767

68-
This the a new feature and it's absolutly compatible with old TiDB versions, also, it does not impact any data migration.
68+
This the a new feature and it's absolutely compatible with old TiDB versions, also, it does not impact any data migration.
6969
The syntax and functions are basically compatible with MySQL expect:
7070

7171
When use invisible index in `SQL Hint`, and set `use_invisible_indexes = false`, MySQL allow use the invisible index.
@@ -76,7 +76,7 @@ The syntax and functions are basically compatible with MySQL expect:
7676
- Add syntax support in parser
7777
- Add a new column `IS_VISIBLE` in `information_schema.statistics`
7878
- Add a new column `VISIBLE` in `SHOW INDEX FROM table` statement
79-
- Show invisiable column infomations in `SHOW CREATE TABLE` statement
79+
- Show invisible column information in `SHOW CREATE TABLE` statement
8080
- Add `use_invisible_indexes` in system variable `@@optimizer_switch`
8181
- Add new error message `ERROR 3522 (HY000): A primary key index cannot be invisible`
8282
- Ignore invisible index in optimizer and add unit tests

0 commit comments

Comments
 (0)