Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical navigation is broken #151

Open
PabloLec opened this issue Oct 16, 2021 · 0 comments
Open

Vertical navigation is broken #151

PabloLec opened this issue Oct 16, 2021 · 0 comments
Labels
Bug Something isn't working

Comments

@PabloLec
Copy link
Contributor

PabloLec commented Oct 16, 2021

Describe the bug
Currently, you cannot use up and down arrow keys to navigate if below element is not in the same column.
This means you can skip rows, e.g go from button on row 1 to button on row 5. But you cannot go from button on row 1, column 1 to button on row 5, column 2. You'll be stuck.

And, as a bonus, I think you can actually select a non selectable widget (.set_selectable(False)) via arrow keys.

To Reproduce
Steps to reproduce the behavior:

  1. Create just two widgets, say two buttons.
  2. Button 1 is on row 1, column 1
  3. Button 2 is on row 2, column 2
  4. Try to use down arrow key.

Expected behavior
You should be able to move to the lower (or upper) nearest neighbor. Current behavior just doesn't feel right. In my case, for RecoverPy, I want to make a form-like view and navigation is just broken at some point.

Screenshots
Current:
not_working

Fixed:
working

I'll publish a PR in a few minutes to fix this issue.

@PabloLec PabloLec added the Bug Something isn't working label Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant