Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional type checking etc. for py_cui functions so errors get caught on startup #129

Open
jwlodek opened this issue Jun 10, 2021 · 0 comments
Assignees
Labels
Bug Something isn't working Core Add for issues having to do with core functions Inputs Issue with regards to keyboard and mouse
Milestone

Comments

@jwlodek
Copy link
Owner

jwlodek commented Jun 10, 2021

Describe the bug
Currently, something like a key_command not being valid will only be caught once the command is executed.

To Reproduce
Steps to reproduce the behavior:

  1. Create a py_cui application
  2. Use the add_key_command function, and add a command that takes in 1 argument
  3. Start the UI, and press the key
  4. UI will crash.

Expected behavior
An error should be spawned at startup when the function is called, for example whenever add_key_command is envoked with an invalid command function

Environment:

  • OS: N/A
  • Terminal: N/A
  • Version: N/A
@jwlodek jwlodek added Bug Something isn't working Core Add for issues having to do with core functions Inputs Issue with regards to keyboard and mouse labels Jun 10, 2021
@jwlodek jwlodek added this to the v0.1.5 milestone Jun 10, 2021
@jwlodek jwlodek self-assigned this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Core Add for issues having to do with core functions Inputs Issue with regards to keyboard and mouse
Projects
None yet
Development

No branches or pull requests

1 participant