Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pxd files not included in PyDAS installation #11

Open
jwallen opened this issue Feb 12, 2015 · 2 comments
Open

.pxd files not included in PyDAS installation #11

jwallen opened this issue Feb 12, 2015 · 2 comments

Comments

@jwallen
Copy link
Owner

jwallen commented Feb 12, 2015

The .pxd files should be installed alongside the compiled modules in order to allow users to easily compile and link Cython modules against PyDAS.

The .pyx files could also be installed in order to provide another way for users to find the source.

@jwallen
Copy link
Owner Author

jwallen commented Feb 12, 2015

The best I've been able to do so far is to get all Python-like files in the root project directory to install by adding the parameter packages=[''] to the setup() call. This grabs all the files we'd want, but also grabs the test files, which I'd rather not have. I'd suggest at least moving the test scripts into a test subdirectory.

The packages=[''] syntax is kind of odd, and seems like it could have unexpected side effects. Therefore it might also make sense to move things into a pydas package, e.g. pydas.dassl and pydas.daspk modules instead of pydas and pydaspk. This would give more intuitive naming, but would require everyone to update their code. Feedback would be welcome on this.

@rwest: Once this is working we can remove the unsightly pydas.pxd file from the RMG-Py root directory.

@rwest
Copy link
Contributor

rwest commented Feb 12, 2015

pydas.dassl and pydas.daspk (and pydas.thenextthing) sounds better to me than pydas (being dassl) and pydaspk (being daspk). I'd be OK with a change that requires code updates in other projects. Especially if there's a way to flag it with a version number bump or something, and a note somewhere obvious about what the required changes are. It would be a bit annoying breaking backwards compatibility though, for example if different topic branches of RMG-Py switch over at different times...

jwallen added a commit that referenced this issue Feb 14, 2015

Verified

This commit was signed with the committer’s verified signature.
zajca Martin Zajíc
The .pxd files are needed to allow others to link against the compiled
pydas.dassl and pydas.daspk modules. The .pyx files are nice to have so that
folks have another means of viewing the code behind the compiled modules.

Closes #11.
rwest added a commit to ReactionMechanismGenerator/PyDAS that referenced this issue Mar 12, 2015
This moves files into new pydas package, and means that software
using this library will need to be modified slightly:

    -from pydas import DASSL
    +from pydas.dassl import DASSL

It also removes DASPK2 and adds DASPK3.1, which allows
sensitivity analysis.

See
jwallen/PyDAS#11
jwallen/PyDAS#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants