Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System proxy fallback doesn't honor nonProxyHosts. #123

Open
Trinition opened this issue Aug 4, 2016 · 0 comments
Open

System proxy fallback doesn't honor nonProxyHosts. #123

Trinition opened this issue Aug 4, 2016 · 0 comments

Comments

@Trinition
Copy link

HTTPClient tries to use the system proxy if one isn't explicitly set. It does this by honoring the http.proxyHost and http.proxyPort system properties to construct a proxy. It does not honor the http.nonProxyHosts system property. What this means is that while any other Java connection will honor the Proxy blacklist, wslite does not.

It might be simple to honor the http.nonProxyHosts property in the existing code. Alternatively, maybe a java.net.ProxySelector can be queried (the sun.net.spi.DefaultProxySelector already honors the blacklist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant