Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - Support for .7z file format in ArchiveInterpreter block #570

Open
4 tasks
robinrj6 opened this issue May 20, 2024 · 3 comments
Open
4 tasks

FEATURE - Support for .7z file format in ArchiveInterpreter block #570

robinrj6 opened this issue May 20, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@robinrj6
Copy link

User Story

  1. As a user
  2. I want to use a .7z compressed file
  3. So that I can use FilePicker to access the .csv file from the compressed file

User Acceptance Criteria

  • {acceptance criteria 1}

Examples

In the case of a dataset created as a result of a journal paper, the paper publishers may release all codes and intermediate data schemas together in a compressed file. 7z format being a lossless compression format, which helps to save space without any loss to the data, is widely preferred.

Notes

Definitions of Done

  • A PR has been opened and accepted
  • All user acceptance criteria are met
  • All tests are passing
@robinrj6 robinrj6 added the enhancement New feature or request label May 20, 2024
@georg-schwarz
Copy link
Member

@robinrj6 Do you have an example data source?

@robinrj6
Copy link
Author

This is the database I tried to download : https://figshare.com/ndownloader/files/37887318. This is a complete project code with datasets of different data schemes all compressed to .7z format.

@rhazn
Copy link
Contributor

rhazn commented May 27, 2024

Hey, thanks for pointing this out, seems like it would be great to support.

If anyone wants to take a stab at this, the extracting is done in the ArchiveInterpreter block and the implementation in the interpreter is here: https://github.com/jvalue/jayvee/blob/b20fcd91d70f5fd04982668f40d10953688c6653/libs/extensions/std/exec/src/archive-interpreter-executor.ts

We are using JSZip (https://stuk.github.io/jszip/) to extract zip archives in the interpreter, sadly it seems to not support 7zip.

In contrast, 7z does but is under GPL license: https://github.com/use-strict/7z-wasm?tab=License-1-ov-file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants