Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin Valuetypes #406

Merged
merged 15 commits into from
Jul 27, 2023
Merged

Builtin Valuetypes #406

merged 15 commits into from
Jul 27, 2023

Conversation

georg-schwarz
Copy link
Member

Introduces builtin valuetypes to the language (replaces former keywords).

Not sure if we really need this, it was majorly for me learning on the job for the builtin blocks. However, users can now click on the builtin valuetypes like text, decimal, integer, and boolean and see their definition in VSCode. This would allow better in-code documentation as we can add comments on the behavior of the builting valuetypes in the standard library.

Screencast.from.07-21-2023.02.53.56.PM.webm

Let me know what you think! If you think it is useful I'd introduce some comments to the builtin valuetypes.

@rhazn
Copy link
Contributor

rhazn commented Jul 26, 2023

Screenshot 2023-07-26 at 18 43 13

Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georg-schwarz georg-schwarz force-pushed the builtin-valuetypes branch 2 times, most recently from 1d8b7ab to b3bba94 Compare July 27, 2023 11:11
@georg-schwarz georg-schwarz merged commit 973044e into dev Jul 27, 2023
2 checks passed
@georg-schwarz georg-schwarz deleted the builtin-valuetypes branch July 27, 2023 11:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants