Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support credential helpers in docker/jib #52

Open
SevereOverfl0w opened this issue Jul 24, 2019 · 2 comments
Open

Support credential helpers in docker/jib #52

SevereOverfl0w opened this issue Jul 24, 2019 · 2 comments

Comments

@SevereOverfl0w
Copy link
Collaborator

https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods

https://static.javadoc.io/com.google.cloud.tools/jib-core/0.10.0/com/google/cloud/tools/jib/frontend/CredentialRetrieverFactory.html

Do we also need to have some way to specify whether to use the helper or the docker config file? Should we also support overriding the location for the docker config file?

@viesti
Copy link
Contributor

viesti commented Jul 26, 2019

Good questions :) I don't remember if I had deep really deep thoughts on registry authentication. Seems that Jib FAQ doesn't recommend passing specific credentials ("Specific credentials (not recommend)" in the faq). Then there is an interesting function inferCredentialHelper() also :)

@SevereOverfl0w
Copy link
Collaborator Author

Yeah, I am a little hesitant about the existence of that, but I guess it's easier to hook into other tools (e.g. gpg -d ~/foo.gpg) so it's not terrible. We should probably figure out how to emphasize the other mechanisms first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants