Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency updating should immedietly update currency_exchange_last_refresh and currency_exchange_historical_last_refresh key #620

Open
applike-ss opened this issue Nov 10, 2021 · 2 comments

Comments

@applike-ss
Copy link
Contributor

The currency updater module should immedietly update the currency_exchange_last_refresh and currency_exchange_historical_last_refresh key to ensure that multiple running tasks that implement the currency module don't start updating all nearly at the same time just because the value of the key is outdated.

@ajscholl
Copy link
Contributor

Then we should also make sure we do some kind of "update this only if it still has the old value", otherwise you can still have two tasks updating the currency values at the same time if they both read and then write in the correct order.

@applike-ss
Copy link
Contributor Author

yes, i was in for a lock as well. @j4k4 what do you think? To lock or not to lock, that is the question. 🔒 🔐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants