Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: Fix sns client name "default" + queue subscription done from sns topics aws account #1029

Open
applike-ss opened this issue Mar 24, 2023 · 0 comments

Comments

@applike-ss
Copy link
Contributor

Currently there are two issues with the stream package.

  1. The client used for creating the sns topic is always "default". However when we run multiple applications in different accounts, we might want to discover their sns topic, so we need to be able to set the client name via the target.GetClientName().
  2. This would lead to another issue we are facing then and that is the way we subscribe something to an sns topic. When the client from the account with the sns topic subscribes something to the topic, there is a subscription notification sent which needs to be confirmed in the destination account. If however we subscribe from the destination account to the source accounts topic, that is not the case.

My suggestion here is to adjust the client name "default" in the stream package to target.GetClientName() and to make the queue subscribe to the topic, not vice versa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant