Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-monorepo): DSW-1969 updated Playwright and Percy dependencies #1663

Closed
wants to merge 2 commits into from

Conversation

JoshuaNg2332
Copy link
Contributor

Describe your changes (can list changeset entries if preferable)

  • Updated Percy and Playwright dependencies
  • Updated tests to support updated Playwright deps

A couple things to note with this PR is that all screenshots added are now covering the Chrome browser.
Some differences in the screenshots of existing packages are due to the change of order in some of the listed variations.

Another note is there is 1 test that has been skipped. This seems to be a legitimate failure of the component test that is blocking this work so a ticket will be written to address this.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving

Reviewer checklists (complete before approving)

Reviewer 1 - @xander-marjoram

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners July 31, 2024 16:06
Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: ec9040d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Contributor


Fails
🚫 You currently have an unchecked checklist item in your PR description.

Please confirm this check has been carried out – if it's not relevant to your PR, delete this line from the PR checklist.

Generated by 🚫 dangerJS against ec9040d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants