feat(pie-webc): DSW-2182 isRtl attr changed to data-is-rtl #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 11ab49b The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
11 tasks
raoufswe
previously approved these changes
Jul 24, 2024
jamieomaguire
previously approved these changes
Jul 24, 2024
dandel10n
dismissed stale reviews from jamieomaguire and raoufswe
The base branch was changed.
dandel10n
force-pushed
the
dsw-2182-rtl-mixin-custom-prop
branch
from
6a20c14 to
11ab49b
Compare
raoufswe
approved these changes
Jul 24, 2024
ashleynolan
approved these changes
Jul 24, 2024
Merged
JoshuaNg2332
pushed a commit
that referenced
this pull request
Jul 25, 2024
* feat(pie-checkbox-group): DSW-2182 enabling/disabling children + aria attr updates * feat(pie-checkbox-group): DSW-2182 checkbox-group styling * feat(pie-webc): DSW-2182 isRtl attr changed to data-is-rtl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"@justeattakeaway/pie-checkbox": patch
"@justeattakeaway/pie-switch": patch
"@justeattakeaway/pie-webc": patch
[Changed] - isRtl attr changed to data-is-rtl