-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-checkbox-group): DSW-2182 checkbox group styling #1618
Conversation
🦋 Changeset detectedLatest commit: 33ef941 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
904c3b2
to
d0d08ec
Compare
eae4834
to
03f79ad
Compare
03f79ad
to
97e4808
Compare
…sses object for classMap
0c0f3a0
to
b68b163
Compare
/snapit |
Starting a new snapshot build. You can view the logs here. |
@dandel10n Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
Describe your changes (can list changeset entries if preferable)
"@justeattakeaway/pie-checkbox": minor
[Changed] - Replaced label prop with a slot to give consumers the option to easily customize the label.
[Changed] - Fixed the rtl styles for the tick/dash for checked/indeterminate state.
[Changed] - Updated visual tests.
"@justeattakeaway/pie-checkbox-group": minor
[Added] - New
isInline
prop.[Added] - Styling for Checkbox Group.
[Added] - Visual tests.
RTL:
Author Checklist (complete before requesting a review)
PIE Storybook
PR preview/snapit
functionality to test my changes in a consuming applicationReviewer checklists (complete before approving)
Reviewer 1 - @xander-marjoram
PIE Storybook
PR previewReviewer 2
PIE Storybook
PR preview