Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-checkbox-group): DSW-2182 checkbox group styling #1618

Merged
merged 13 commits into from
Jul 24, 2024

Conversation

dandel10n
Copy link
Contributor

@dandel10n dandel10n commented Jul 18, 2024

Describe your changes (can list changeset entries if preferable)


"@justeattakeaway/pie-checkbox": minor

[Changed] - Replaced label prop with a slot to give consumers the option to easily customize the label.
[Changed] - Fixed the rtl styles for the tick/dash for checked/indeterminate state.
[Changed] - Updated visual tests.


"@justeattakeaway/pie-checkbox-group": minor

[Added] - New isInline prop.
[Added] - Styling for Checkbox Group.
[Added] - Visual tests.

Screenshot 2024-07-23 at 14 42 28

Screenshot 2024-07-23 at 14 42 17

RTL:

Screenshot 2024-07-23 at 14 44 04

Screenshot 2024-07-23 at 14 43 58

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • If visual tests are required for the component, I have created a project in Percy
  • I have reviewed the PIE Storybook PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1 - @xander-marjoram

  • I have reviewed the PIE Storybook PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the PIE Storybook PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Jul 18, 2024

🦋 Changeset detected

Latest commit: 33ef941

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@justeattakeaway/pie-checkbox Minor
@justeattakeaway/pie-checkbox-group Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-vanilla Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dandel10n dandel10n changed the title Dsw 2182 checkbox group styling feat(pie-checkbox-group): DSW-2182 checkbox group styling Jul 18, 2024
@dandel10n dandel10n force-pushed the dsw-2182-checkbox-group-styling branch 2 times, most recently from 904c3b2 to d0d08ec Compare July 19, 2024 15:20
@dandel10n dandel10n force-pushed the dsw-2182-checkbox-group-styling branch 4 times, most recently from eae4834 to 03f79ad Compare July 23, 2024 08:44
@dandel10n dandel10n marked this pull request as ready for review July 23, 2024 09:01
@dandel10n dandel10n requested review from a team as code owners July 23, 2024 09:01
@xander-marjoram xander-marjoram self-requested a review July 23, 2024 09:12
@ashleynolan ashleynolan self-requested a review July 23, 2024 10:27
.changeset/polite-carpets-mix.md Outdated Show resolved Hide resolved
packages/components/pie-checkbox-group/src/index.ts Outdated Show resolved Hide resolved
packages/components/pie-checkbox-group/src/index.ts Outdated Show resolved Hide resolved
apps/pie-storybook/stories/pie-checkbox-group.stories.ts Outdated Show resolved Hide resolved
packages/components/pie-checkbox-group/src/defs.ts Outdated Show resolved Hide resolved
packages/components/pie-checkbox/src/index.ts Show resolved Hide resolved
@dandel10n dandel10n force-pushed the dsw-2182-checkbox-group-styling branch from 03f79ad to 97e4808 Compare July 23, 2024 11:52
@dandel10n
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@dandel10n Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@dandel10n dandel10n merged commit d47b4cc into main Jul 24, 2024
35 checks passed
@dandel10n dandel10n deleted the dsw-2182-checkbox-group-styling branch July 24, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants