Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pie-modal): DSW-000 pie modal page object refactor #1359

Merged
merged 6 commits into from
Mar 27, 2024
Merged

refactor(pie-modal): DSW-000 pie modal page object refactor #1359

merged 6 commits into from
Mar 27, 2024

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Mar 26, 2024 •
edited
Loading

Describe your changes (can list changeset entries if preferable)

  • Updated pie modal page object to match format in pie cookie banner

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code

Reviewer checklists (complete before approving)

Reviewer 1

  • No docs site changes.

Reviewer 2

  • No docs site changes.

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners March 26, 2024 16:39
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bcd8494

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jamieomaguire
jamieomaguire previously approved these changes Mar 26, 2024
View reviewed changes
siggerzz
siggerzz requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@siggerzz siggerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment regarding variables name!

jamieomaguire
jamieomaguire previously approved these changes Mar 27, 2024
View reviewed changes
siggerzz
siggerzz requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@siggerzz siggerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments around naming

xander-marjoram
xander-marjoram approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@xander-marjoram xander-marjoram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff

@JoshuaNg2332 JoshuaNg2332 merged commit 8c757d0 into main Mar 27, 2024
38 of 39 checks passed
@JoshuaNg2332 JoshuaNg2332 deleted the dsw-000-refactor-modal-page-object branch March 27, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xander-marjoram xander-marjoram xander-marjoram approved these changes

@siggerzz siggerzz siggerzz approved these changes

@jamieomaguire jamieomaguire jamieomaguire left review comments

Assignees
No one assigned
Labels
components pie-modal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoshuaNg2332 @siggerzz @jamieomaguire @xander-marjoram