Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-input): DSW-1586 add size property to input component #1354

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

jamieomaguire
Copy link
Contributor

@jamieomaguire jamieomaguire commented Mar 26, 2024

Describe your changes (can list changeset entries if preferable)

Adds a new size property to pie-input. Styling will come in an upcoming ticket.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • If it is a component change, I have reviewed the Storybook preview

Reviewer checklists (complete before approving)

Reviewer 1

  • If it is a component change, I have reviewed the Storybook preview

Reviewer 2

  • If it is a component change, I have reviewed the Storybook preview
    (Reviewed by @xander-marjoram)

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: f9e0c88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
pie-storybook Minor
@justeattakeaway/pie-input Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamieomaguire jamieomaguire marked this pull request as ready for review March 26, 2024 09:41
@jamieomaguire jamieomaguire requested review from a team as code owners March 26, 2024 09:41
@jamieomaguire jamieomaguire merged commit 31a1b0a into main Mar 26, 2024
66 of 70 checks passed
@jamieomaguire jamieomaguire deleted the dsw-1586-size-prop branch March 26, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants