From ac5d0422b275ce421007cc365c25d2e27b72337b Mon Sep 17 00:00:00 2001
From: Xander Marjoram <xander.marjoram@justeattakeaway.com>
Date: Thu, 25 Jul 2024 16:20:26 +0100
Subject: [PATCH] More changes from self-review

---
 packages/components/pie-cookie-banner/src/index.ts | 5 ++---
 packages/components/pie-modal/src/defs.ts          | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/packages/components/pie-cookie-banner/src/index.ts b/packages/components/pie-cookie-banner/src/index.ts
index 996d52c826..53488d581f 100644
--- a/packages/components/pie-cookie-banner/src/index.ts
+++ b/packages/components/pie-cookie-banner/src/index.ts
@@ -229,7 +229,6 @@ export class PieCookieBanner extends LitElement implements CookieBannerProps {
     }
 
     render () {
-        const leadingActionText = this._localiseText('preferencesManagement.cta.save.label');
         return html`
         <pie-modal
             .isOpen="${this._isModalOpen}"
@@ -237,9 +236,9 @@ export class PieCookieBanner extends LitElement implements CookieBannerProps {
             hasStackedActions
             isFullWidthBelowMid
             heading="${this._localiseText('preferencesManagement.title')}"
-            leadingActionText="${leadingActionText}"
+            leadingActionText="${this._localiseText('preferencesManagement.cta.save.label')}"
             leadingActionVariant="primary"
-            .aria=${{ leadingActionLabel: leadingActionText }}
+            .aria=${{ leadingActionLabel: this._localiseText('preferencesManagement.cta.save.label') }}
             @pie-modal-leading-action-click="${this._handlePreferencesSaved}"
             @pie-modal-back="${this._displayCookieBanner}">
                 ${this.renderModalContent()}
diff --git a/packages/components/pie-modal/src/defs.ts b/packages/components/pie-modal/src/defs.ts
index 25b1e8fa27..7e13122305 100644
--- a/packages/components/pie-modal/src/defs.ts
+++ b/packages/components/pie-modal/src/defs.ts
@@ -146,7 +146,7 @@ export const ON_MODAL_SUPPORTING_ACTION_CLICK = 'pie-modal-supporting-action-cli
 
 export type ModalActionType = 'leading' | 'supporting';
 
-export type DefaultProps = ComponentDefaultProps<ModalProps, keyof Omit<ModalProps, 'aria' | 'heading' | 'returnFocusAfterCloseSelector' | 'leadingActionText' | 'supportingActionText'>>;
+export type DefaultProps = ComponentDefaultProps<ModalProps, keyof Omit<ModalProps, 'aria' | 'heading' | 'leadingActionText' | 'supportingActionText' | 'returnFocusAfterCloseSelector'>>;
 
 export const defaultProps: DefaultProps = {
     hasBackButton: false,