From 04891f5a0bd9d880b731db3bf15d87600e2b59d2 Mon Sep 17 00:00:00 2001 From: Raouf Date: Mon, 29 Jan 2024 16:37:47 +0100 Subject: [PATCH] fix(pie-tag): DSW-000 address design feedback (#1226) * fix(pie-tag): DSW-000 address design feedback * fix(pie-tag): DSW-000 address design feedback --------- Co-authored-by: Ashley Watson-Nolan --- .changeset/wet-cobras-burn.md | 7 +++++++ packages/components/pie-tag/src/tag.scss | 8 ++++---- 2 files changed, 11 insertions(+), 4 deletions(-) create mode 100644 .changeset/wet-cobras-burn.md diff --git a/.changeset/wet-cobras-burn.md b/.changeset/wet-cobras-burn.md new file mode 100644 index 0000000000..3b0cd9c074 --- /dev/null +++ b/.changeset/wet-cobras-burn.md @@ -0,0 +1,7 @@ +--- +"@justeattakeaway/pie-tag": minor +--- + +[Changed] - The icon colour of blue-strong, green-strong, and red strong variants should be "content-inverse" +[Changed] - The icon and label colour of the yellow-subtle variant should be "content-default" + diff --git a/packages/components/pie-tag/src/tag.scss b/packages/components/pie-tag/src/tag.scss index b9e3597c7a..7035f96ec9 100644 --- a/packages/components/pie-tag/src/tag.scss +++ b/packages/components/pie-tag/src/tag.scss @@ -75,7 +75,7 @@ &[isStrong] { --tag-bg-color: var(--dt-color-support-info); - --tag-color: var(--dt-color-content-light); + --tag-color: var(--dt-color-content-inverse); } } @@ -85,13 +85,13 @@ &[isStrong] { --tag-bg-color: var(--dt-color-support-positive); - --tag-color: var(--dt-color-content-light); + --tag-color: var(--dt-color-content-inverse); } } &[variant='yellow'] { --tag-bg-color: var(--dt-color-support-warning-02); - --tag-color: var(--dt-color-content-dark); + --tag-color: var(--dt-color-content-default); &[isStrong] { --tag-bg-color: var(--dt-color-support-warning); @@ -105,7 +105,7 @@ &[isStrong] { --tag-bg-color: var(--dt-color-support-error); - --tag-color: var(--dt-color-content-light); + --tag-color: var(--dt-color-content-inverse); } }