Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes are absent in changelog for 11.0.0-beta.4 version #917

Open
rkalita opened this issue Jan 13, 2021 · 1 comment
Open

Breaking changes are absent in changelog for 11.0.0-beta.4 version #917

rkalita opened this issue Jan 13, 2021 · 1 comment

Comments

@rkalita
Copy link

rkalita commented Jan 13, 2021

Describe the Bug

As i can see, you guys(since 11.0.0-beta.4) updated webpack-merge package version from 5.7.0 to 5.7.3. Please, add breaking changes in angular.json

Minimal Reproduction

Previously i was using 11.0.0-beta.1 version of your lib, so now, after migration to 11.0.0 i need to change angular.json config.
Old version:

"build": {
          "builder": "@angular-builders/custom-webpack:browser",
          "customWebpackConfig": {
              "path": "./custom-webpack.config.js",
              "mergeStrategies": {
                "module.rules": "prepend"
              },
              "replaceDuplicatePlugins": true
            },
            ...

New version:

"build": {
          "builder": "@angular-builders/custom-webpack:browser",
          "customWebpackConfig": {
            "path": "./custom-webpack.config.js",
            "mergeRules": {
              "module": {
                "rules": "prepend"
              }
            },
            "replaceDuplicatePlugins": true
          },
          ...

So please, add an info about these breaking changes into CHANGELOG file

Screenshots

image

Environment


Libs
- @angular-builders/custom-webpack: 11.0.0
@just-jeb
Copy link
Owner

@rkalita Thanks for bringing it up. This information is available in migration guide (for stable releases), but you're right of course about adding this change to the change log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants