fix(connector): Ideal and multiple other failing PMs fixed in Ayden #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
Sweta-Kumari-Sharma
force-pushed
the
fix-trustly-ideal-inAdyen
branch
from
85476b4 to
c982913
Compare
Sweta-Kumari-Sharma
force-pushed
the
fix-trustly-ideal-inAdyen
branch
2 times, most recently
from
f12e759 to
72f0a94
Compare
Sweta-Kumari-Sharma
force-pushed
the
fix-trustly-ideal-inAdyen
branch
from
2c5bc04 to
5c7849b
Compare
Sweta-Kumari-Sharma
changed the title
Comment on lines
+507
to
+516
| pub enum PaymentMethod<'a> { | ||
| AdyenPaymentMethod(Box<AdyenPaymentMethod<'a>>), | ||
| AdyenMandatePaymentMethod(Box<AdyenMandatePaymentMethod>), | ||
| } | ||
| #[derive(Debug, Clone, Serialize)] | ||
| #[serde(untagged)] | ||
| #[serde(rename_all = "lowercase")] | ||
| pub enum AdyenMandatePaymentMethod { | ||
| Mandate(Box<AdyenMandate>), | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub enum PaymentMethod<'a> { | |
| AdyenPaymentMethod(Box<AdyenPaymentMethod<'a>>), | |
| AdyenMandatePaymentMethod(Box<AdyenMandatePaymentMethod>), | |
| } | |
| #[derive(Debug, Clone, Serialize)] | |
| #[serde(untagged)] | |
| #[serde(rename_all = "lowercase")] | |
| pub enum AdyenMandatePaymentMethod { | |
| Mandate(Box<AdyenMandate>), | |
| } | |
| pub enum PaymentMethod<'a> { | |
| AdyenPaymentMethod(Box<AdyenPaymentMethod<'a>>), | |
| AdyenMandatePaymentMethod(Box<AdyenMandate>), | |
| } |
Can we make this change ?
| Atome, | ||
| #[serde(rename = "Scheme")] |
There was a problem hiding this comment.
Adyen Bancontact requests require scheme to be passed as the type. However, we are currently passing Scheme, which could cause issues(may not be in sandbox, but there is a possibility of this happening in prod) . We cannot assign the same name for both BancontactCard and AdyenCard. Therefore, can we remove BancontactCard(Box) and use AdyenCard(Box) for BancontactCard as well, adding validations for Bancontact card-specific fields while populating the value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
TrustlyandIdealBank Redirect payments were failing forAyden.Trustlyerror message:Required object 'paymentMethod' is not provided.Idealerror message:Could not find issuer for issuerIdFor
Trustly, populated thepaymentMethodto fix the issue.Idealis moving to a more centralized infrastructure to process payments, which does not need issuer. So removed issuer field from connector request body.Reference: https://docs.adyen.com/payment-methods/ideal/api-only/
Multiple PMTs were failing due to this error
Required object 'paymentMethod' is not provided.fixed.Additional Changes
Motivation and Context
https://github.com/juspay/hyperswitch-cloud/issues/8251
How did you test it?
Response
Response
Checklist
cargo +nightly fmt --allcargo clippy