Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: invite users enhancement #1964

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Dec 23, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • showing loader modal while switch merchant and profile in invite users
  • displaying "All Profiles" by default in profile dropdown to indicate merchant level user being invited

Motivation and Context

How did you test it?

  • changes visible in invite users page

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Dec 23, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner December 23, 2024 10:07
Copy link

Review changes with  SemanticDiff

@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Dec 23, 2024
@gitanjli525 gitanjli525 linked an issue Dec 23, 2024 that may be closed by this pull request
Copy link
Collaborator

@JeevaRamu0104 JeevaRamu0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach some screen shot or video of how it works

@@ -28,12 +28,12 @@ let make = (~isInviteUserFlow=true, ~setNewRoleSelected=_ => ()) => {
// TODO : Change this condition when user org level user_invite is enabled
initialvalue->Array.pushMany([
("merchant_value", merchantId->JSON.Encode.string),
("profile_value", profileId->JSON.Encode.string),
("profile_value", "all_profiles"->JSON.Encode.string),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please recheck this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Status: issues related to core S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE]: invite user changes
2 participants