chore: Remove unused feature flags and codeblocks #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication_analytics, system_metrics, live_users_counter
…ication_analytics, system_metrics, live_users_counter
susrithasabbini
added
S-waiting-on-review
|
Review changes with Changed Files
|
susrithasabbini
changed the title
github-actions
bot
added
the
S-conventions-not-followed
susrithasabbini
added
S-conventions-not-followed
susrithasabbini
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
| {switch url.path->urlPath { | ||
| | list{"home"} => | ||
| <RenderIf condition=isLiveUsersCounterEnabled> | ||
| <ActivePaymentsCounter /> |
There was a problem hiding this comment.
why have you removed the component rendering <ActivePaymentsCounter />
you can just remove the feature flag and renderif condition
| @@ -208,25 +200,6 @@ let make = () => { | |||
| /> | |||
| </AccessControl> | |||
| | list{"users", ..._} => <UserManagementContainer /> | |||
| | list{"analytics-user-journey"} => | |||
| <AccessControl | |||
| isEnabled={featureFlagDetails.userJourneyAnalytics && | |||
Comment on lines
-212
to
-213
| <AccessControl | ||
| isEnabled={featureFlagDetails.userJourneyAnalytics && |
There was a problem hiding this comment.
why have we removed the component ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Removed unused feature flags and codeblocks that used the following feature flags
Motivation and Context
Code cleaning, removed code blocks and feature flags that are not necessary.
How did you test it?
Where to test it?
Checklist
npm run re:build