Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new analytics api repeated fix #1836

Closed
wants to merge 1 commit into from

Conversation

sagarnaikjuspay
Copy link
Contributor

@sagarnaikjuspay sagarnaikjuspay commented Dec 2, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

when api is beign called two times with same payload wherever the module which has a dependency on comparision range
even thoutgh the comparision is diabled the comparision date ranges do updated when primary date range is changes
image

Motivation and Context

How did you test it?

the api should be called once the comparision is disabled or enabled

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sagarnaikjuspay sagarnaikjuspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed bug bug analytics labels Dec 2, 2024
@sagarnaikjuspay sagarnaikjuspay self-assigned this Dec 2, 2024
@sagarnaikjuspay sagarnaikjuspay requested a review from a team as a code owner December 2, 2024 16:18
Copy link

Review changes with  SemanticDiff

@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed bug bug analytics labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

analytics api beign called twice in module having comparison dependency
1 participant