-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some playwright ui tests #33
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.github/workflows/build.yml
Outdated
@@ -106,14 +106,17 @@ jobs: | |||
- name: Install the extension | |||
run: | | |||
set -eux | |||
python -m pip install --pre jupyterlite-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there could be a pin on jupyterlite-core
here, as new versions may bring some visual changes that would make the UI tests fail?
For example jupyterlite-core==0.5.0
will be based on JupyterLab 4.3 and Notebook 7.3, which may have some CSS changes compared to jupyterlite-core==0.4.x
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll do that.
please update snapshots |
please update snapshots |
I've moved the deployment-related files into their own I have tried to modify |
Great, that's something I wanted to do at some point as a follow- up to #28 👍
Right, it looks related to this issue in JupyterLite: jupyterlite/jupyterlite#1095 |
deploy/requirements-deploy.txt
Outdated
jupyterlab>=4,<5 | ||
jupyterlite-core>=0.4,<0.5 | ||
jupyterlite-pyodide-kernel | ||
. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need to update to get the extension from the parent directory now:
. | |
.. |
Thanks @jtpio, it is all working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add some playwright ui tests, following a similar approach to that used in
jupyterlite
andpyodide-kernel
repositories. Currently there are tests for:Note hiding file modification times so that tests are repeatable.
More tests will be added in future.
Fixes #20.