From 1a96514539154d427119253baa7d544ab8ca159b Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Wed, 3 Apr 2024 11:28:55 -0500 Subject: [PATCH] Do not try and handle deps on Windows (#229) --- .github/actions/base-setup/action.yml | 8 ++++++++ README.md | 4 +++- package.json | 6 +++--- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/.github/actions/base-setup/action.yml b/.github/actions/base-setup/action.yml index bb0178f..904cc92 100644 --- a/.github/actions/base-setup/action.yml +++ b/.github/actions/base-setup/action.yml @@ -132,6 +132,14 @@ runs: elif [ $DEPENDENCY_TYPE == 'minimum' ]; then FLAGS="--resolution=lowest-direct" fi + if [ "$RUNNER_OS" == "Windows" ]; then + if [ -n "$FLAGS" ]; then + echo "dependency_type not supported on Windows" + exit 1 + else + exit 0 + fi + fi if [ -f pyproject.toml ]; then uv pip compile $FLAGS pyproject.toml -o $HOME/constraints.txt echo "PIP_CONSTRAINT=$HOME/constraints.txt" >> $GITHUB_ENV diff --git a/README.md b/README.md index 8e75491..f8f8b33 100644 --- a/README.md +++ b/README.md @@ -51,6 +51,7 @@ environment variable, so that installations will use that file. By default the Python version will be "3.7", which can be overridden with `python_version`. Note that the environment variable also works if you use virtual environments like `hatch`. +Note: this does not work on Windows, and will error. ```yaml minimum_version: @@ -68,12 +69,13 @@ you use virtual environments like `hatch`. run: pytest ``` -If you want to use your minimum dependencies, you can use the following +If you want to use your pending dependencies, you can use the following option, which will create a constraints file and set the `PIP_CONSTRAINT` environment variable, so that installations will use that file. By default the Python version will be "3.12", which can be overridden with `python_version`. Note that the environment variable also works if you use virtual environments like `hatch`. +Note: this does not work on Windows, and will error. ```yaml prereleases: diff --git a/package.json b/package.json index 0c302bd..8b1266d 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "name": "@jupyterlab/maintainer-tools", - "version": "0.25.2", - "private": true + "name": "@jupyterlab/maintainer-tools", + "version": "0.25.2", + "private": true }