Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignores changes below certain cells #1350

Open
mesvam opened this issue Sep 11, 2024 · 0 comments
Open

ignores changes below certain cells #1350

mesvam opened this issue Sep 11, 2024 · 0 comments
Labels

Comments

@mesvam
Copy link

mesvam commented Sep 11, 2024

Description

I discovered a case where the extension is not showing diffs below a particular cell. The cell output contains a large image. I've exported a minimal subsection of the notebook that reproduces the issue: attached here: test.zip

Reproduce

  1. Init a git repo, and add the notebook file and make a commit
  2. Change the text in the first cell "above", save the notebook, and make a commit
  3. Change the text in the last cell "below", save the notebook, and make a commit
  4. Open the sidebar in Juypter-lab, go to the last commit and click the "View file changes" icon

Current behavior

Changes to the cell "above" are displayed correctly, but changes to the cell "below" do not appear. The display shows as if the file is unchanged.

Expected behavior

Changes to all cells should display as diffs

Context

  • Python package version:
# packages in environment at C:\Users\<redacted>\AppData\Local\Programs\Miniconda3:
#
# Name                    Version                   Build  Channel
jupyterlab-git            0.50.0          py311haa95532_0
  • Extension version:
JupyterLab v4.2.4
C:\Users\<redacted>\AppData\Local\Programs\Miniconda3\share\jupyter\labextensions
        ipyparallel-labextension v8.6.1 enabled  X
        jupyter-matplotlib v0.11.3 enabled ok
        nbdime-jupyterlab v3.0.1 enabled ok
        @jupyter-widgets/jupyterlab-manager v5.0.10 enabled ok (python, jupyterlab_widgets)
        @jupyterlab/git v0.50.0 enabled ok (python, jupyterlab-git)


   The following extensions may be outdated or specify dependencies that are incompatible with the current version of jupyterlab:
        ipyparallel-labextension

   If you are a user, check if an update is available for these packages.
   If you are a developer, re-run with `--verbose` flag for more details.
  • Git version:
    git version 2.39.2
  • Operating System and its version:
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Web Browser Output
Paste the output from your browser web console here.
@mesvam mesvam added the bug label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant