Message attachments #148
Message attachments #148
Conversation
|
|
| export interface IChatMessage<T = IUser, U = IAttachment> { | ||
| type: 'msg'; | ||
| body: string; | ||
| id: string; | ||
| time: number; | ||
| sender: T; | ||
| attachments?: U[]; |
There was a problem hiding this comment.
Does it make sense to type attachments as a generic type argument if we're providing an interface (IAttachment)? This allows any generic type U, including primitives like number or boolean which may not be handled by the backend.
I think it makes sense to require attachments to all be dictionaries and enforce an interface:
| export interface IChatMessage<T = IUser, U = IAttachment> { | |
| type: 'msg'; | |
| body: string; | |
| id: string; | |
| time: number; | |
| sender: T; | |
| attachments?: U[]; | |
| export interface IChatMessage<T = IUser> { | |
| type: 'msg'; | |
| body: string; | |
| id: string; | |
| time: number; | |
| sender: T; | |
| attachments?: IAttachment[]; |
There was a problem hiding this comment.
This interface is reused in jupyterlab-chat packages with the IYmessage. In this case, it is only an id of an attachment (same as the users), to avoid saving several time the same attachment in the final document.
brichet
force-pushed
the
message_attachments
branch
from
d3cfaae to
a96b7e5
Compare
|
Thanks for the review @dlqqq, I addressed some of your comments. I'll take a look at an alternative to |
Co-authored-by: David L. Qiu <[email protected]>
Co-authored-by: David L. Qiu <[email protected]>
brichet
force-pushed
the
message_attachments
branch
from
2658548 to
f9f5a6b
Compare
packages/jupyter-chat/src/model.ts
Outdated
| /** | ||
| * A signal emitting when the input attachments changed. | ||
| */ | ||
| readonly inputAttachmentsChanges?: ISignal<IChatModel, IAttachment[]>; |
There was a problem hiding this comment.
Maybe with the following spelling, similar to the names of other signals?
| readonly inputAttachmentsChanges?: ISignal<IChatModel, IAttachment[]>; | |
| readonly inputAttachmentsChanged?: ISignal<IChatModel, IAttachment[]>; |
|
The recurrent failing test do not fails locally. And strangely, it constantly fails at opening the chat, which is done in other tests with the same chat file... |
Draft implementation of #147
EDIT:
Updating the screen-cast
record-2025-02-13_11.04.21.webm
There is now a lite deployment in the built doc including a simple extension with a chat panel. I updated it to allow attachments https://jupyter-chat--148.org.readthedocs.build/en/148/lite/lab/index.html