Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI broken since release of 4.3.0 #93

Closed
fcollonval opened this issue Nov 21, 2024 · 0 comments · Fixed by #94
Closed

CI broken since release of 4.3.0 #93

fcollonval opened this issue Nov 21, 2024 · 0 comments · Fixed by #94
Labels
bug Something isn't working

Comments

@fcollonval
Copy link
Member

Description

CI is broken for pnpm since 4.3.0 release due to that upstream PR: jupyterlab/jupyterlab#16288

Reproduce

Check any CI workflow: https://github.com/jupyterlab/extension-template/actions/workflows/main.yml

Expected behavior

No CI failures

The fix is likely to apply the tsconfig changes as in the JupyterLab PR.
@fcollonval fcollonval added the bug Something isn't working label Nov 21, 2024
@fcollonval fcollonval mentioned this issue Nov 21, 2024
Merged
@fcollonval fcollonval linked a pull request Nov 21, 2024 that will close this issue
Update tsconfig lib #94
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tsconfig lib jupyterlab/extension-template
1 participant
@fcollonval