Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain byte are incorrectly replaced to EFBFBD when opening a local binary file in /drive (while /drive is referring to Local Files) #49

Open
tanaga9 opened this issue Jan 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@tanaga9
Copy link
Contributor

tanaga9 commented Jan 9, 2023

Description

Certain byte are incorrectly replaced to EFBFBD when opening a local binary file in /drive.
(while /drive is referring to Local Files)
(Found by chance in #48)

Reproduce

read a local binary file in /drive.

Expected behavior

do not replace

Context

  • JupyterLite version: 0.1.0-beta.17
  • jupyterlab-filesystem-access version: v0.5.3
  • Browser and its version: Chrome 108.0.5359.124 (Official Build) (x86_64)

Is it because the format of the binary file is text instead of base64 ?

We assume here image, audio and video mimetypes are all and only binary files we'll encounter

oops, i opened the zip file

sc_20230109_162545

@tanaga9 tanaga9 added the bug Something isn't working label Jan 9, 2023
@tanaga9
Copy link
Contributor Author

tanaga9 commented Jan 18, 2023

I want to list "mimetypes" that should be treated as plain text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant