Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo by remove extra - in docker call #3252

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Fix typo by remove extra - in docker call #3252

merged 1 commit into from
Mar 10, 2025

Conversation

rgaiacs
Copy link
Collaborator

@rgaiacs rgaiacs commented Mar 10, 2025

This was introduced in #3249 and missed in #3250.

@rgaiacs rgaiacs requested a review from yuvipanda March 10, 2025 08:21
@rgaiacs rgaiacs self-assigned this Mar 10, 2025
manics
manics approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we get
#3158
finished we can hopefully test all PRs in GitHub CI and pick these up

@manics manics merged commit 77506a9 into jupyterhub:main Mar 10, 2025
8 checks passed
@yuvipanda
Copy link
Contributor

damn. ty for catching and fixing this, @rgaiacs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics approved these changes

@yuvipanda yuvipanda Awaiting requested review from yuvipanda

Assignees

@rgaiacs rgaiacs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgaiacs @yuvipanda @manics