[WIP] Streamline deployment of GESIS acceptance server #3178
Conversation
Jupyter Hub and Binder Hub uses ingressClassName instead of className.
as indicated in https://helm.sh/docs/chart_best_practices/templates/#comments-yaml-comments-vs-template-comments to pass Helm lint.
because it is already present.
rgaiacs
force-pushed
the
gesis-methods-hub
branch
from
75b3ca0 to
9823278
Compare
|
This is ready for review. If it looks good, please merge. The @arnim this does not include the custom GESIS page. This will go in another PR. |
rgaiacs
force-pushed
the
gesis-methods-hub
branch
from
def6a62 to
ec006f7
Compare
|
I think this is fine- though would you mind minimising the changes to the templates, or alternatively put the reformatting into a separate PR and ideally add whatever formatter you're using to pre-commit? |
I will do at the end of the month. Busy with a couple of things. |
In response to jupyterhub#3178 (comment), I realized we can automate all this now.
Turns out just setting it on NotebookApp doesn't set it on ServerApp now, and so all of our templates were actually just no-ops for a while. Discovered while testing jupyterhub#3178
|
@rgaiacs if you can give me access to https://github.com/gesiscss/mybinder.org-deploy/tree/gesis-methods-hub, i can push the required changes and get this merged! |
|
@yuvipanda Thanks for the message. I cannot give you access to https://github.com/gesiscss. I can push a new merge request from https://github.com/rgaiacs but this will have the same side effect of you push a new merge request from your user. You have my permission to take over this. I'm only be able to devote some time in March. |
|
I haven't been able to touch this, but also feel uncomfortable merging this myself because I know how to test its effects on the GESIS setup :( |
rgaiacs
changed the title
This is related with #2797 and #3087.
SSH access to GESIS Kubernetes cluster requires access to GESIS VPN. This makes the use of GitHub actions challenge.
Different than #3090, this PR assumes that the GESIS Kubernetes is configured. GESIS Kubernetes runs on bare-metal and is configured following MetalLB + Ingress NGINX Controller.
GESIS operates a on-premise GitLab. This PR addes a GitLab CI/CD configuration to deploy the mybinder.org Helm chart to the GESIS Kubernetes using GitLab agent for Kubernetes.
After #3159, any the commit on
mainis pushed to GESIS GitLab and will trigger a new deployment of this mybinder.org Helm chart.At the moment, the Helm chart deploy fails with
My understanding of the error is that GESIS Kubernetes already has a Ingress Class
nginxthat was configured for MetalLB + Ingress NGINX Controller but the Binder Hub and Jupyter Hub upstream Helm chart tries to create the same Ingress Classnginxand this operation is blocked. Is my understanding correct? @manics @yuvipanda @minrk