Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authentication with docker cli #1943

Open
rgaiacs opened this issue Mar 11, 2025 · 0 comments · May be fixed by #1945
Open

Update authentication with docker cli #1943

rgaiacs opened this issue Mar 11, 2025 · 0 comments · May be fixed by #1945

Comments

@rgaiacs
Copy link
Contributor

rgaiacs commented Mar 11, 2025

As reported in jupyterhub/mybinder.org-deploy#3253, BinderHub instances using Docker Hub as container registry will encounter authentication issues because base64 user:password and user:token is not accepted by Docker Hub.

We need to use

cat ~/my_password.txt | docker login --username foo --password-stdin

This is how the Docker's login GitHub Action operates, see https://github.com/docker/login-action/blob/327cd5a69de6c009b9ce71bce8395f28e651bf99/src/docker.ts#L35.

This change is limited to Docker Hub. For example, Project Quay continues to mention base64 user:token in their documentation.

rgaiacs added a commit to rgaiacs/binderhub that referenced this issue Mar 11, 2025
@rgaiacs rgaiacs linked a pull request Mar 11, 2025 that will close this issue
rgaiacs added a commit to rgaiacs/binderhub that referenced this issue Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant