Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI tests for the suggestion panel #618

Open
trungleduc opened this issue Dec 1, 2024 · 2 comments
Open

Add UI tests for the suggestion panel #618

trungleduc opened this issue Dec 1, 2024 · 2 comments
Labels
maintenance
Milestone
3.1.0

Comments

@trungleduc
Copy link
Member 

          This PR is ready, this suggestion panel is hidden if the `fork` feature is unavailable. I will add UI tests later once `jupyter-collaboration` 3.1 is released

Originally posted by @trungleduc in #579 (comment)
@martinRenou martinRenou added this to the 3.1.0 milestone Dec 4, 2024
@arjxn-py
Copy link
Member

What kind of tests are we thinking to add for suggestions panel?
I think I'd like to give it a try in upcoming days

@trungleduc
Copy link
Member Author

trungleduc commented Dec 19, 2024 •
edited
Loading

Just do something with the suggestion panel then take screenshots: add new suggestion, edit object, accept/discard suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@trungleduc @martinRenou @arjxn-py