Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logoicon as tabicon #466

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Add logoicon as tabicon #466

merged 1 commit into from
Oct 10, 2024

Conversation

arjxn-py
Copy link
Member

Should close #459

image

@arjxn-py arjxn-py added the enhancement New feature or request label Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Integration tests repot: appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

Preview PR at appsharing.space

martinRenou
martinRenou approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice! Thanks!

We should do the same for jupytergis

@martinRenou martinRenou merged commit 2a39e90 into jupytercad:main Oct 10, 2024
10 checks passed
@arjxn-py arjxn-py mentioned this pull request Oct 10, 2024
Merged
@arjxn-py
Copy link
Member Author

We should do the same for jupytergis

Done geojupyter/jupytergis#183 😁

@arjxn-py arjxn-py deleted the tabicon branch October 10, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing icon in dock area tab header
2 participants
@arjxn-py @martinRenou